[run_rocm_test] Check XNACK status before testing USM tests #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USM support requires xnack to be enabled in the system. Smoke family of test suites use SKIP_USM env var to disable USM tests from compilation and execution. This PR ensures that the underlying system has xnack mode enabled before scheduling USM tests on it.
saiislam
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
|
It fixes SWDEV-510644. USM tests were failing on gfx908 machine which has been booted into xnack disabled mode. |
ronlieb
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USM support requires xnack to be enabled in the system. Smoke family of test suites use SKIP_USM env var to disable USM tests from compilation and execution.
This PR ensures that the underlying system has xnack mode enabled before scheduling USM tests on it.